🐛 Replace deprecated set-output with GITHUB_OUTPUT #2384
Conversation
gabibguti
requested review from
azeemshaikh38,
justaugustus,
laurentsimon,
naveensrinivasan and
spencerschrock
as code owners
|
Integration tests success for |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2384 +/- ##
=======================================
Coverage 40.61% 40.61%
=======================================
Files 112 112
Lines 8831 8831
=======================================
Hits 3587 3587
Misses 4984 4984
Partials 260 260 |
No problem! Not sure which link do you mean tho. Workflow file links Action links |
They both say
You can trigger the goreleaser workflow by pushing a tag to your fork
You can trigger the slsa-goreleaser manually by following this |
|
Should I modify anything in these workflows to test? Like changing |
As far as I know, that just determines if a release gets updated to your fork which is fine https://github.com/gabibguti/scorecard/releases I see the SLSA releaser failed, but the output value seems to have worked https://github.com/gabibguti/scorecard/actions/runs/3300430916/jobs/5444920630#step:1:29 |
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com>
|
Integration tests success for |
|
Just for reference, I tested the goreleaser workflow and everything seems fine. Goreleaser failed 'cause I did not set a GPG key secret in my fork, but the version_ldflags output was set fine in the previous step. I tested echo-ing the version_ldflags output in a separate workflow. |
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com> Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com> Signed-off-by: latortuga <latortugaaaa>
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com> Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com> Signed-off-by: nathaniel.wert <nathaniel.wert@kudelskisecurity.com>
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com> Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com> Signed-off-by: nathaniel.wert <nathaniel.wert@kudelskisecurity.com>
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com> Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com>
What kind of change does this PR introduce?
Replace deprecated set-output with GITHUB_OUTPUT on workflows.
What is the current behavior?
Use set-output to set outputs in workflows.
What is the new behavior (if this is a feature change)?**
Use GITHUB_OUTPUT to set outputs in workflows.
Which issue(s) this PR fixes
Fixes #2376
Special notes for your reviewer
I was not able to run E2E tests with make e2e-pat.
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)
NONE